@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @icewind1991 and @LukasReschke to be potential reviewers.

OK. 41b185b fixes the issue.
However, when an unauthorized user clicks a restricted folder the directory changes to his home directory, which not a very intuitive behavior at least. It would be nicer if this behaviour could be changed to: do not do anything at all (and eventually popup a message box "restricted....") or display an empty folder stub with some hint that the access has been denied.

please dont leave commented out code lying around

please dont leave commented out code lying around

I will add a comment to it.
Would like to keep the code to know that we had it and what it caused...

Codecov Report

Merging #5124 into master will decrease coverage by 16.51%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #5124       +/-   ##
=============================================
- Coverage     54.14%   37.63%   -16.52%     
+ Complexity    22285    22284        -1     
=============================================
  Files          1379     1379               
  Lines         85336    85328        -8     
  Branches       1322     1322               
=============================================
- Hits          46208    32114    -14094     
- Misses        39128    53214    +14086

The pull request fixes the issue but it open an other can of worms:
file access control can be removed if user has access to parent folder #66
(which is for me a grave issue since it effectively disables access control based on the FAC application)
I suppose this is the reason why the lines commented out in the pull request were there in the first place.

@MorrisJobke @icewind1991 please review as this needs backporting for 12.0.1

Instead of not throwing the exception it seems better to me to handle the exception in folder listing and hide the problematic entry

That's bad, as it would cause sync clients to delete the file?

Lets just revert the change from vincent which caused this by accident. Our codebase worked fine without it

there are 2 +1 and robin +1ed the comment, so merging